-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add swagger for REST API #2
base: develop
Are you sure you want to change the base?
Conversation
type : string | ||
requestBody: | ||
required: true | ||
content: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PUT method.
Missing the fields available to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we intend to allow updating only status, no?
|
||
info: | ||
title: Crasher REST API | ||
description: Current API describes UI interaction with Crasher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we consider "Crasher" as the whole system that consists of UI, language libraries and server? If so let's say with Crasher Server.
description: url path for next pagination page | ||
required: | ||
- totalSize | ||
- self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does server tells a client that it was the last page? By totalSize = 0
?
- 0 | ||
- 1 | ||
- 2 | ||
- 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to me that it can be bad approach to make enums in rest api, i think it's better to use string representations of status.
500: | ||
description: Server error | ||
delete: | ||
summary: Delete all core dumps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add some optional parameters, by application, by status and etc.?
type : string | ||
requestBody: | ||
required: true | ||
content: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we intend to allow updating only status, no?
No description provided.