Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add swagger for REST API #2

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

VladimirBalun
Copy link
Contributor

No description provided.

@VladimirBalun VladimirBalun added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 18, 2022
type : string
requestBody:
required: true
content:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PUT method.
Missing the fields available to update.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we intend to allow updating only status, no?


info:
title: Crasher REST API
description: Current API describes UI interaction with Crasher
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we consider "Crasher" as the whole system that consists of UI, language libraries and server? If so let's say with Crasher Server.

description: url path for next pagination page
required:
- totalSize
- self
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does server tells a client that it was the last page? By totalSize = 0?

- 0
- 1
- 2
- 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to me that it can be bad approach to make enums in rest api, i think it's better to use string representations of status.

500:
description: Server error
delete:
summary: Delete all core dumps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add some optional parameters, by application, by status and etc.?

type : string
requestBody:
required: true
content:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we intend to allow updating only status, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants