Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc build #1668

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Fix doc build #1668

merged 5 commits into from
Nov 27, 2024

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Nov 27, 2024

Reason for this pull request

API and click documentation is not rendering in the 1.9 docs build.

Proposed changes

  • Updated documentation requirements.txt. Had to do by hand as pyproj seems to be breaking pip-compile somehow.

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes


📚 Documentation preview 📚: https://datacube-core--1668.org.readthedocs.build/en/1668/

@SpacemanPaul SpacemanPaul marked this pull request as draft November 27, 2024 01:15
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (22dc077) to head (001ff62).
Report is 1 commits behind head on develop-1.9.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop-1.9    #1668   +/-   ##
============================================
  Coverage        85.54%   85.54%           
============================================
  Files              143      143           
  Lines            15422    15422           
============================================
  Hits             13193    13193           
  Misses            2229     2229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review November 27, 2024 01:46
Copy link
Contributor

@caitlinadams caitlinadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, much appreciated!

@SpacemanPaul SpacemanPaul merged commit ab54b35 into develop-1.9 Nov 27, 2024
26 checks passed
@SpacemanPaul SpacemanPaul deleted the fix-doc-build branch November 27, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants