Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include DEA's new offshore territories tag #335

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

jeremyh
Copy link
Collaborator

@jeremyh jeremyh commented Mar 7, 2024

... and add a test case of a modern wagl output.

The added test data found a bug unrelated to the offshore territories: when the first measurement has no explicit CRS it fails with a reference error.

  • (Bands don't all need to declare the CRS explicitly, because they should all be the same CRS. But this failed when it was the first band that was not explicit.)

I've also unwisely included a few housekeeping commits here.

  • Enabled DTDs again fro the Modis packager. This was tightened some time ago for our securtiy linter, but the production datasets from the US require them. The processor was only recently upgraded to a (much) newer version of eodatasets so this was never picked up.
    -Pre-commit bump

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.44%. Comparing base (bd57906) to head (e080e1c).
Report is 6 commits behind head on develop.

Files Patch % Lines
eodatasets3/prepare/nasa_c_m_mcd43a1_6_prepare.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #335      +/-   ##
===========================================
+ Coverage    84.37%   84.44%   +0.06%     
===========================================
  Files           26       26              
  Lines         4506     4506              
===========================================
+ Hits          3802     3805       +3     
+ Misses         704      701       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeremyh jeremyh requested a review from uchchwhash March 7, 2024 01:04
@jeremyh jeremyh marked this pull request as ready for review March 7, 2024 01:06
@jeremyh
Copy link
Collaborator Author

jeremyh commented Mar 7, 2024

(The Docker Push action is failing for an unrelated reason — missing dockerhub credentials. I'm not an repo admin so can't view/setup credentials #336)

uchchwhash
uchchwhash previously approved these changes Mar 7, 2024
Copy link
Member

@uchchwhash uchchwhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jeremyh jeremyh merged commit 412e57e into opendatacube:develop Mar 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants