Fix GHA: PG admin tools have moved #621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omad
force-pushed
the
push-rkquntpkmxsq
branch
6 times, most recently
from
1c0c3cb
to
4c1ff15
Compare
Previously, a postgres data directory was being manually created using the low level postgres admin tools like initdb and pg_ctl. This broke, because the Ubuntu postgresql package moved those tools to /usr/lib/postgresql/14/bin. When I added that to the path, the server still failed to start, so lets use the more common pattern within GHA, and run Postgresql as a service, updating the environment variables to use it.
omad
force-pushed
the
push-rkquntpkmxsq
branch
from
4c1ff15
to
546451e
Compare
omad
force-pushed
the
push-rkquntpkmxsq
branch
from
985381b
to
3484a24
Compare
|
@omad the second commit seems to fix issues with running/accessing postgres. Do you think there are more issues with postgres, or are the remaining issues you have discovered related to other things? If the remaining issues are not related to postgres, this PR is a strict improvement over main and you might as well merge it. I understand there will still be test failures on the main branch after merging, but regular test failures are easier to debug for most people. (If you get time later to fix those issues that is great, but I understand you no longer work with opendatacube and I know how hard it is to do this kind of stuff on weekends and evenings.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.