add simple chatbot definition #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we move this to Should we add the python code and the Containerfile used as well? |
Signed-off-by: sallyom <[email protected]>
cooktheryan
reviewed
Nov 6, 2024
|
|
||
| Update the deployment as necessary and | ||
| run this from the root of the repository | ||
|
|
There was a problem hiding this comment.
maybe just add a line in here describing the line that must be changed and an exampl
tumido
reviewed
Nov 7, 2024
Comment on lines
+9
to
+11
| finalizers: | ||
| - inferenceservice.finalizers | ||
| generation: 2 |
There was a problem hiding this comment.
These will populate automatically and are managed by the cluster itself, do not set them manually.
| labels: | ||
| opendatahub.io/dashboard: "true" | ||
| name: candidatemodel | ||
| namespace: ilab |
There was a problem hiding this comment.
Maybe move the namespace to kustomization.yaml?
|
|
||
|
|
||
| ```bash | ||
| oc apply --kustomize ./chatbot |
There was a problem hiding this comment.
Suggested change
| oc apply --kustomize ./chatbot | |
| oc apply -k . |
| storage: | ||
| key: aws-connection-ilab-s3 | ||
| # Update path to match canddidate-server location | ||
| path: xxxxxxxx/xxxxxxxxx/pvc-to-model-op/model/phase_2/model/hf_format/candidate_model/ |
There was a problem hiding this comment.
If you do helm chart instead of kustomize, you can easily template this from values/CLI params. Just a thought...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure we want this in the repo, but here it is.