[WIP] DO NOT MERGE! implementing conditional pipeline logic #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Clifford <[email protected]>
tumido
reviewed
Nov 21, 2024
|
|
||
| # Pipelines | ||
|
|
||
| # some pre-filght image that checks all params and fails if something is wrong. |
There was a problem hiding this comment.
Maybe we can revive #21 efforts?
There was a problem hiding this comment.
That's a good idea.
tumido
reviewed
Nov 22, 2024
| after=output_pvc_task, | ||
| ) | ||
|
|
||
| with dsl.If(sdg_only == True and train_only == False, name="SDG Only"): |
There was a problem hiding this comment.
Can we flip the toggles? It may be more intuitive that way... like remove the *_only meaning from it:
| Param names | Default value |
|---|---|
run_sdg |
True |
run_train |
True |
So it would work like this:
run_sdg value |
run_train value |
Outcome |
|---|---|---|
| True | True | Full run |
| True | False | Only SDG is run |
| False | True | Oly Training is run |
| False | False | Nothing happens |
WDYT?
There was a problem hiding this comment.
yes, that is much better 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental PR to share feasibility of making the pipeline stages optional based on user configuration