Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled s390x Build Method #30

Open
wants to merge 50 commits into
base: dev
Choose a base branch
from

Conversation

sudharshanibm
Copy link

@sudharshanibm sudharshanibm commented May 13, 2024

What type of PR is this?

Feature

What this PR does / why we need it:

This PR will add the support for s390x for multi-arch image build

Special notes for your reviewer:

Successfully created multi-arch images and pushed into local image registry. Created images on Openshift platform runs on s390x architecture. We have also shared screenshots for the same.

Does this PR introduce a user-facing change?

NONE

Image : quay.io/smuralid/kueue:v0.6.2-odh-3-gfdafd7a7-dirty

image

image

image

Change-Id: Iaad4e043f8c295edbe16fa08f8ad431d8d96d8e5

Co-authored-by: Aldo Culquicondor <[email protected]>
Change-Id: I325b633421e009cd3f7ae5b48ddcf0d3da46741d
Change-Id: I2b2aa88eca55d3385cb34cf141b5da3c902c28d7

Co-authored-by: Aldo Culquicondor <[email protected]>
* Don't deploy visibility by default

* Review Remarks

* Review Remarks

* Review Remarks

---------

Co-authored-by: Traian Schiau <[email protected]>
* Parallelize integration tests

* Create parameter INTEGRATION_NPROCS

* test INTEGRATION_NPROCS=2

* test INTEGRATION_NPROCS=8

* revert INTEGRATION_NPROCS

---------

Co-authored-by: Gabe <[email protected]>
Use a custom service account and role when generating
the multikueue kubeconfigs.

Co-authored-by: Traian Schiau <[email protected]>
…t. (kubernetes-sigs#1809)

* Cluster connection monitoring and reconnect.

* Review Remarks

---------

Co-authored-by: Traian Schiau <[email protected]>
Change-Id: I5e44372ee23b253c6eeb2a71c8a97dd0370e5072

Co-authored-by: Aldo Culquicondor <[email protected]>
…-sigs#1832)

* Avoid requeue on ClusterQueue status update

Change-Id: Id028414a730a238549b7fddf5d42a2eafdf959c3

* Reclaimable pods can put pod out of inadmissible

Change-Id: Id52ef3c92abd84317c4a7a71c3a20f6f28d67d25

* Delay requeueing based on RequeueState

Change-Id: I5431e741cb30541a846b65fb26aa0b7b631eb80d

---------

Co-authored-by: Aldo Culquicondor <[email protected]>
Change-Id: If8f430731a6967a361d0f5172ed408f57a0687bc

Co-authored-by: Aldo Culquicondor <[email protected]>
…sigs#1830) (kubernetes-sigs#1836)

* [e2e] Return ginkgo exit code

* [e2e] Restore manager's image in sh

* Cleanup and remarks

Change-Id: I66ccb5173149458dfcdd64d117dd81cd3ded9c5c

Co-authored-by: Traian Schiau <[email protected]>
…d=false (kubernetes-sigs#1845)

Change-Id: Ib10c1874bfb3f5810f83d751e4d80ca6eb031bfa
Change-Id: I7cc659b2b013cd4a0b907b0e3002b877dac2e4ae
)

Change-Id: I69584dd95c57539e163067a4fb93cdb32fc57461

Co-authored-by: Aldo Culquicondor <[email protected]>
…kubernetes-sigs#1880)

Change-Id: I68155a467880059c65deb75b00939b14551924cd

Co-authored-by: Aldo Culquicondor <[email protected]>
…s-sigs#1917)

* Dereference StopPolicy before equality check

* Update pkg/controller/core/workload_controller.go

Co-authored-by: Yuki Iwai <[email protected]>

* Update pkg/controller/core/workload_controller.go

Co-authored-by: Yuki Iwai <[email protected]>

---------

Co-authored-by: Gabe <[email protected]>
Co-authored-by: Yuki Iwai <[email protected]>
Change-Id: I7f17d51df66de6766af44e48f45b4165e8bd3e30

Co-authored-by: Aldo Culquicondor <[email protected]>
Change-Id: Icabeb0cca6f7680173d72be29a293731f93d8f9b
@openshift-ci openshift-ci bot requested review from Maxusmusti and tedhtchang May 13, 2024 06:56
Copy link

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sudharshanibm
Once this PR has been reviewed and has the lgtm label, please assign astefanutti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented May 13, 2024

Hi @sudharshanibm. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@maxamillion
Copy link

Unless I'm missing something, this PR should likely be against the upstream Kueue repo. https://github.com/opendatahub-io/kueue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.