Implement Prometheus metrics for LocalQueue (#3673) #55
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
KPostOffice
force-pushed
the
lq-metrics
branch
from
99ee06a to
63fa660
Compare
* add LocalQueue metrics (no feature gate) Signed-off-by: Kevin <[email protected]> * add all clear and report calls Signed-off-by: Kevin <[email protected]> * add feature gate Signed-off-by: Kevin <[email protected]> * cleanup todos and add more feature gates Signed-off-by: Kevin <[email protected]> * use feature gate instead of config Signed-off-by: Kevin <[email protected]> * cleanup Signed-off-by: Kevin <[email protected]> * add metrics checks to a test Signed-off-by: Kevin <[email protected]> * add lq metrics to cq integration test Signed-off-by: Kevin <[email protected]> * lint fix Signed-off-by: Kevin <[email protected]> * use name instead of local_queue Signed-off-by: Kevin <[email protected]> * update status metric description Signed-off-by: Kevin <[email protected]> * fix key name Signed-off-by: Kevin <[email protected]> * move registerLQ into metrics package Signed-off-by: Kevin <[email protected]> --------- Signed-off-by: Kevin <[email protected]>
KPostOffice
force-pushed
the
lq-metrics
branch
from
63fa660 to
d46377c
Compare
|
/retest |
KPostOffice
force-pushed
the
lq-metrics
branch
from
d46377c to
a6c69c6
Compare
Signed-off-by: Kevin <[email protected]>
KPostOffice
force-pushed
the
lq-metrics
branch
from
a6c69c6 to
b859cc2
Compare
|
/retest |
|
@KPostOffice: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I was debugging this test and noticed that the image being used when I ran the test was |
cherry pick of local-queue metrics features