Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH: Remove deprecated kube-rbac-proxy. manual cherry-pick of 422b41e #56

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

akram
Copy link

@akram akram commented Dec 19, 2024

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Remove deprecated kube-rbac-proxy.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove deprecated kube-rbac-proxy

Copy link

openshift-ci bot commented Dec 19, 2024

@akram: The label(s) kind/cleanup, kind/deprecation cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Remove deprecated kube-rbac-proxy.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove deprecated kube-rbac-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akram akram changed the title Remove deprecated kube-rbac-proxy. manual cherry-pick of 422b41e PATCH: Remove deprecated kube-rbac-proxy. manual cherry-pick of 422b41e Dec 19, 2024
Copy link

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @akram!

@KPostOffice
Copy link

/approve

Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, KPostOffice, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eb81deb into opendatahub-io:dev Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants