fix: sqlite query escaping

opendatahub-io · Feb 21, 2024 · f9770ba · f9770ba
1 parent ec2c7b1
commit f9770ba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ml_metadata/metadata_store/query_config_executor.cc b/ml_metadata/metadata_store/query_config_executor.cc
@@ -283,11 +283,11 @@ absl::Status QueryConfigExecutor::DowngradeMetadataSource(
 }
 
 std::string QueryConfigExecutor::Bind(const char* value) {
-  return metadata_source_->EscapeString(value);
+  return absl::StrCat("'", metadata_source_->EscapeString(value), "'");
 }
 
 std::string QueryConfigExecutor::Bind(absl::string_view value) {
-  return metadata_source_->EscapeString(value);
+  return absl::StrCat("'", metadata_source_->EscapeString(value), "'");
 }
 
 std::string QueryConfigExecutor::Bind(int value) {

diff --git a/ml_metadata/metadata_store/sqlite_metadata_source.cc b/ml_metadata/metadata_store/sqlite_metadata_source.cc
@@ -174,7 +174,7 @@ absl::Status SqliteMetadataSource::RollbackImpl() {
 }
 
 std::string SqliteMetadataSource::EscapeString(absl::string_view value) const {
-  return SqliteEscapeString(value);
+  return absl::StrCat("'", SqliteEscapeString(value), "'");
 }
 
 std::string SqliteMetadataSource::EncodeBytes(absl::string_view value) const {