Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Known Issues Section to README.md File #109

Closed

Conversation

tonyxrmdavidson
Copy link

This PR adds a Known Issues section to the README.md file for repository.

Description

New section added titled Known Issues
First known issue added to describe and mitigate the issue of image pull rate limiting against mysql;8.3.0.

How Has This Been Tested?

Although there are no code changes in this PR the work around for the error described has been tested agaisnt several openshift clusters running opendatahub.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

@isinyaaa isinyaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Tony :)

README.md Outdated Show resolved Hide resolved
Copy link

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isinyaaa, tonyxrmdavidson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [isinyaaa,tonyxrmdavidson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Aug 20, 2024
Copy link

openshift-ci bot commented Aug 20, 2024

New changes are detected. LGTM label has been removed.

This commit will add a Known Issues section and also add information about a known image rate limiting issue which occasionally causes an ImagePullBackoff error

Signed-off-by: tonyxrmdavidson <[email protected]>

Requested Changes from @isinyaaa accepted

Co-authored-by: Isabella Basso <[email protected]>

Removing Unused Codeblock
This commit removes the unused codeblock

Signed-off-by: tonyxrmdavidson <[email protected]>
Copy link

openshift-ci bot commented Aug 20, 2024

@tonyxrmdavidson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-model-registry-python-client d0a1c95 link false /test e2e-odh-model-registry-python-client
ci/prow/e2e-odh-mro-optional d0a1c95 link false /test e2e-odh-mro-optional
ci/prow/images d0a1c95 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this PR be filed upstream? 🤔

a good FAQ place is also: https://github.com/kubeflow/model-registry/blob/main/CONTRIBUTING.md?plain=1#L219

@tarilabs
Copy link
Member

@tarilabs tarilabs closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants