-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: align manifest images #131
chore: align manifest images #131
Conversation
Signed-off-by: Matteo Mortari <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.2.8 #131 +/- ##
===============================================
Coverage 77.58% 77.58%
===============================================
Files 24 24
Lines 2159 2159
Branches 145 145
===============================================
Hits 1675 1675
Misses 287 287
Partials 197 197 ☔ View full report in Codecov by Sentry. |
note: build job successfull (the one doing unit, integration) and same for python testing. ...seems to me a circular dependency issue. I propose to move the GHA job build-and-test-image to the Model Registry Operator, cc @Al-Pragliola what is your pov here? since the job build-and-test-image is mainly to dry-run the operator deploys the image, proceeding anyway with the release, since testing is done both upstream and unit, integration testing with the other GHA jobs |
700d3eb
into
opendatahub-io:release/v0.2.8
Absolutely, I agree with you @tarilabs that the MR operator is dependent on the MR. So I think it is wrong to do the integration test here in MR, I would also move it to the operator. If we want to avoid the scenario where we release MR v0.x.y and then see that it breaks with the MR operator and we have to re-release or bump to MR v0.x.y+1, we can include the use of RCs in both repos and then when everything is green do the release. |
this is a great idea @Al-Pragliola thank you for the suggestion. As discussed offline, for the next time, I will do branching "at once" in both repos. Since we release from main, this is possibly a simple way to test this. Can always opt for RC strategy when we have some changes that requires attention in the interaction between the operator and MR. |
No description provided.