Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align manifest for 0.2.10 for ODH #144

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Nov 8, 2024

Description

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@openshift-ci openshift-ci bot requested review from lampajr and rareddy November 8, 2024 14:32
Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.63%. Comparing base (6a0f0d1) to head (78546fe).

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v0.2.10     #144   +/-   ##
================================================
  Coverage            73.63%   73.63%           
================================================
  Files                   24       24           
  Lines                 2515     2515           
  Branches                74       74           
================================================
  Hits                  1852     1852           
  Misses                 466      466           
  Partials               197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarilabs tarilabs added the lgtm label Nov 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7b691af into opendatahub-io:release/v0.2.10 Nov 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants