Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync upstream KF into midstream ODH #15

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Mar 4, 2024

this will require a new image build

lampajr and others added 6 commits February 22, 2024 10:54
* kubeflow: change go module name and references

Signed-off-by: Andrea Lamparelli <[email protected]>

* kubeflow: rename odh. into kfmr.

Signed-off-by: tarilabs <[email protected]>

* kubeflow: py: pyproject description

Signed-off-by: tarilabs <[email protected]>

* kubeflow: nit picks in text documents

Signed-off-by: tarilabs <[email protected]>

---------

Signed-off-by: Andrea Lamparelli <[email protected]>
Signed-off-by: tarilabs <[email protected]>
Co-authored-by: tarilabs <[email protected]>
* fix: OpenAPI metadata discriminator

Signed-off-by: tarilabs <[email protected]>

* wiring factories and default values missed in codegen

Signed-off-by: tarilabs <[email protected]>

* introduce openapi defaults

Signed-off-by: tarilabs <[email protected]>

* fix TestMetadataValue*

Signed-off-by: Andrea Lamparelli <[email protected]>

* fix: type assert generation

Signed-off-by: Andrea Lamparelli <[email protected]>

* upgrade openapi spec version to v1alpha2

Signed-off-by: Andrea Lamparelli <[email protected]>

---------

Signed-off-by: tarilabs <[email protected]>
Signed-off-by: Andrea Lamparelli <[email protected]>
Co-authored-by: tarilabs <[email protected]>
…low#20)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.1 to 1.62.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.61.1...v1.62.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* gitignore: ignore all coverage files

Signed-off-by: Isabella Basso do Amaral <[email protected]>

* OAS: fix discriminator field for Artifact

Signed-off-by: Isabella Basso do Amaral <[email protected]>

---------

Signed-off-by: Isabella Basso do Amaral <[email protected]>
@tarilabs tarilabs requested a review from a team March 4, 2024 09:29
@openshift-ci openshift-ci bot added the approved label Mar 4, 2024
@rkubis
Copy link

rkubis commented Mar 4, 2024

/approve

Copy link

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rkubis, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6ae59f5 into opendatahub-io:main Mar 4, 2024
11 checks passed
@lampajr
Copy link

lampajr commented Mar 4, 2024

@tarilabs @rkubis not sure this was really merged with merge-commit 🤔

@tarilabs
Copy link
Member Author

tarilabs commented Mar 4, 2024

@tarilabs @rkubis not sure this was really merged with merge-commit 🤔

yes, that's a BIG problem the label was maintained: #15 (comment)

tarilabs added a commit to tarilabs/model-registry that referenced this pull request Mar 4, 2024
tarilabs added a commit to tarilabs/model-registry that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants