Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from kubeflow:main #20

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Mar 6, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@openshift-ci openshift-ci bot requested review from dhirajsb and nehachopra27 March 6, 2024 03:35
Copy link

openshift-ci bot commented Mar 6, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.43%. Comparing base (022a263) to head (ece101a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   76.19%   76.43%   +0.24%     
==========================================
  Files          17       17              
  Lines        2033     2054      +21     
  Branches       74       74              
==========================================
+ Hits         1549     1570      +21     
  Misses        299      299              
  Partials      185      185              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarilabs
Copy link
Member

tarilabs commented Mar 6, 2024

/ok-to-test

@rkubis
Copy link

rkubis commented Mar 6, 2024

/approve

Copy link

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pull[bot], rkubis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 6, 2024
@tarilabs
Copy link
Member

tarilabs commented Mar 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f149df6 into opendatahub-io:main Mar 6, 2024
11 checks passed
@tarilabs tarilabs mentioned this pull request Mar 6, 2024
3 tasks
rhods-devops-app bot referenced this pull request in red-hat-data-services/model-registry Mar 13, 2024
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.1 to 1.62.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.61.1...v1.62.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
rhods-devops-app bot referenced this pull request in red-hat-data-services/model-registry Mar 13, 2024
* kubeflow: fix go module and odh. debranding (#15)

* kubeflow: change go module name and references

Signed-off-by: Andrea Lamparelli <[email protected]>

* kubeflow: rename odh. into kfmr.

Signed-off-by: tarilabs <[email protected]>

* kubeflow: py: pyproject description

Signed-off-by: tarilabs <[email protected]>

* kubeflow: nit picks in text documents

Signed-off-by: tarilabs <[email protected]>

---------

Signed-off-by: Andrea Lamparelli <[email protected]>
Signed-off-by: tarilabs <[email protected]>
Co-authored-by: tarilabs <[email protected]>

* Fix metadata OpenAPI spec (#17)

* fix: OpenAPI metadata discriminator

Signed-off-by: tarilabs <[email protected]>

* wiring factories and default values missed in codegen

Signed-off-by: tarilabs <[email protected]>

* introduce openapi defaults

Signed-off-by: tarilabs <[email protected]>

* fix TestMetadataValue*

Signed-off-by: Andrea Lamparelli <[email protected]>

* fix: type assert generation

Signed-off-by: Andrea Lamparelli <[email protected]>

* upgrade openapi spec version to v1alpha2

Signed-off-by: Andrea Lamparelli <[email protected]>

---------

Signed-off-by: tarilabs <[email protected]>
Signed-off-by: Andrea Lamparelli <[email protected]>
Co-authored-by: tarilabs <[email protected]>

* kubeflow: make MLMD type names (and prefix) pluggable (#19)

Signed-off-by: Matteo Mortari <[email protected]>

* build(deps): bump google.golang.org/grpc from 1.61.1 to 1.62.0 (#20)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.61.1 to 1.62.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.61.1...v1.62.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* OAS: Fix discriminator field definition for Artifact (#22)

* gitignore: ignore all coverage files

Signed-off-by: Isabella Basso do Amaral <[email protected]>

* OAS: fix discriminator field for Artifact

Signed-off-by: Isabella Basso do Amaral <[email protected]>

---------

Signed-off-by: Isabella Basso do Amaral <[email protected]>

---------

Signed-off-by: Andrea Lamparelli <[email protected]>
Signed-off-by: tarilabs <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Isabella Basso do Amaral <[email protected]>
Co-authored-by: Andrea Lamparelli <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Isabella Basso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants