Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This commit adds a README.md for openshift-ci usage #44

Merged
merged 4 commits into from
Apr 12, 2024
Merged

This commit adds a README.md for openshift-ci usage #44

merged 4 commits into from
Apr 12, 2024

Conversation

tonyxrmdavidson
Copy link

This commit adds a README.md for openshift-ci usage explaining how to locally run the script and how to start the associated openshift-ci job.

@openshift-ci openshift-ci bot requested review from dhirajsb and rareddy April 11, 2024 11:12
@tonyxrmdavidson tonyxrmdavidson requested review from a team and removed request for dhirajsb and rareddy April 11, 2024 11:12
tarilabs
tarilabs reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, thank you

openshift-ci/README.md Outdated Show resolved Hide resolved
openshift-ci/README.md Show resolved Hide resolved
tarilabs
tarilabs reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, thank you

openshift-ci/README.md Outdated Show resolved Hide resolved
tonyxrmdavidson and others added 2 commits April 11, 2024 13:28
@tonyxrmdavidson @tarilabs
Update openshift-ci/README.md
5dbd792 
Accepted tarilabs suggestion

Co-authored-by: Matteo Mortari <[email protected]>
@tonyxrmdavidson
rebasing
ca3e449
@tonyxrmdavidson
Copy link
Author

/retest

1 similar comment
@tonyxrmdavidson
Copy link
Author

/retest

@tonyxrmdavidson @tarilabs
Update openshift-ci/README.md
37138e2 
Co-authored-by: Matteo Mortari <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 11, 2024

@tonyxrmdavidson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-cfo 37138e2 link true /test e2e-odh-cfo

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkubis
Copy link

rkubis commented Apr 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 12, 2024
@rkubis
Copy link

rkubis commented Apr 12, 2024

/approve

tarilabs
tarilabs approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rkubis, tarilabs, tonyxrmdavidson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [rkubis,tarilabs,tonyxrmdavidson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tonyxrmdavidson tonyxrmdavidson merged commit a1ee20b into opendatahub-io:main Apr 12, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarilabs tarilabs tarilabs approved these changes

Assignees

@tarilabs tarilabs

@rkubis rkubis

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyxrmdavidson @rkubis @tarilabs