Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GHA kind test update following MRO update #6

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix: GHA kind test update following MRO update #6

merged 1 commit into from
Feb 21, 2024

Conversation

tarilabs
Copy link
Member

realign to opendatahub-io/model-registry-operator#60 following CI broken

Description

How Has This Been Tested?

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • [n/a] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [n/a] The developer has manually tested the changes and verified that the changes work

@tarilabs tarilabs requested a review from lampajr February 21, 2024 10:25
lampajr
lampajr approved these changes Feb 21, 2024
View reviewed changes
Copy link

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this @tarilabs!

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lampajr, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Member Author

this is required to re-establish GHA CI green, proceeding to merge.

@tarilabs tarilabs merged commit 9ba89a3 into opendatahub-io:main Feb 21, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lampajr lampajr lampajr approved these changes

@tonyxrmdavidson tonyxrmdavidson Awaiting requested review from tonyxrmdavidson

Assignees

@lampajr lampajr

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarilabs @lampajr