Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Kubernetes secret instead of users credentials #1416

Merged

Conversation

harshad16
Copy link
Member

Switch to Kubernetes secret instead of users credentials
Closes: #1415

Description

How Has This Been Tested?

Test Impact

Request review criteria:

  • The commits have meaningful messages (squashes happen on merge by the bot).
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

@harshad16 harshad16 force-pushed the fix-elyra-secrets branch 2 times, most recently from 4ab2af7 to 854cfac Compare June 21, 2023 16:10
@harshad16 harshad16 force-pushed the fix-elyra-secrets branch from 854cfac to 82d5417 Compare June 21, 2023 16:25
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Let us test the image first before merging.

@openshift-ci openshift-ci bot added do-not-merge/hold This PR is hold for some reason lgtm labels Jun 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member Author

Tested on a cluster:

Screenshot from 2023-06-21 13-30-55
The changes are showing up nicely in the generation.

@andrewballantyne
Copy link
Member

/unhold

LGTM

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Jun 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit d50509b into opendatahub-io:main Jun 21, 2023
andrewballantyne pushed a commit that referenced this pull request Jun 22, 2023
harshad16 added a commit to red-hat-data-services/odh-dashboard that referenced this pull request Jun 22, 2023
Switch to Kubernetes secret instead of users credentials (opendatahub-io#1416)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Switch to kubernets_secret option in place of user_credential option on elyrasecret
3 participants