Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle multiple tags filter on datasets #50

Merged
merged 2 commits into from
Nov 28, 2024
Merged

feat: handle multiple tags filter on datasets #50

merged 2 commits into from
Nov 28, 2024

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Nov 21, 2024

Same as opendatateam/udata#3204 but for search service.

abulte
abulte commented Nov 21, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
@abulte abulte marked this pull request as ready for review November 21, 2024 16:36
@abulte abulte mentioned this pull request Nov 21, 2024
Merged
5 tasks
magopian
magopian approved these changes Nov 26, 2024
View reviewed changes
Copy link

@magopian magopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one once again! Congratz, very clean and easy to understand.

Do we also want the search service to be queried with multiple tags for topics? (I'm not knowledgeable on the topics yet, maybe it doesn't make sense?)

udata_search_service/presentation/utils.py Show resolved Hide resolved
udata_search_service/presentation/utils.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
udata_search_service/infrastructure/search_clients.py Show resolved Hide resolved
udata_search_service/presentation/api.py Show resolved Hide resolved
maudetes
maudetes approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR as well! 👏

pyproject.toml Show resolved Hide resolved
tests/test_search_client.py Outdated Show resolved Hide resolved
magopian
magopian approved these changes Nov 27, 2024
View reviewed changes
Copy link

@magopian magopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@maudetes maudetes merged commit 978379a into opendatateam:main Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magopian magopian magopian approved these changes

@maudetes maudetes Awaiting requested review from maudetes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abulte @magopian @maudetes