-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sumac Release Notes #622
Open
feoh
wants to merge
35
commits into
openedx:main
Choose a base branch
from
feoh:cpatti_sumac_relnotes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−6
Open
Sumac Release Notes #622
Changes from 26 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
f551b19
feat: Preliminary cut of Sumac release notes. Incomplete.
feoh e305eeb
docs: initial cut of release notes for OpenEdX Sumac
feoh 0cbdc8f
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh c8d76fa
docs: Add note about newly enabled by default sidebar toggle.
feoh a6ba69c
docs: Added new settings for Sumac. (Still need to add feature toggles).
feoh 8862dc9
docs: Add most feature toggles
feoh d647d80
docs: Add missing feature flags from other repos.
feoh 484412b
docs: Add zooming image tool DEPR
feoh fb062a1
docs: Add blank line to trigger Sphinx rebuild
feoh a094d09
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 01efc6b
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh c64064e
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 4bbeb8f
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 74b9f4b
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 61c1cc6
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 44263ca
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 0dc6106
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh d917c51
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 52ce181
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh ae099ce
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 2f7c1f9
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh c052956
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 7effbb6
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh f7c0429
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh fc9f81c
docs: Add link to Sumac upgrade feature PR.
feoh cca982a
docs: Make Sabrina suggested category consolidation
feoh 970b2c8
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh aa5abb4
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 96968dc
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh a1056a1
docs: Add removed toggles as per review feedback.
feoh 111cd50
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 3dec30b
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 2d130d9
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh 450c28a
docs: Add DEPR meeting results from Peter and fix RST bogons.
feoh 8d33834
Update source/community/release_notes/sumac/dev_op_release_notes.rst
feoh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add this line IF it is true, because otherwise reading the rendered page it's a bit unclear how the headers nest. But I want to check in on this - @arbrandes @bradenmacdonald @regisb @feanil - no breaking changes in Sumac? Who else should I tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ormsbee or @kdmccormick ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feoh I didn't mean for you to commit this at this time. We need to check if there are any breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crap itchy trigger finger. Unresolving. Will fix if people find breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I'm sorry :) I'll fix it if people raise anything but I'm not going to create a revision to fix a thing which in fact may not be broken :) I'll stay on top of this and ensure the page reflects reality. Sorry for prematurely pulling the trigger!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is atleast openedx/edx-platform#35185 which should be captured here as a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil That PR is not included in Sumac as far as I can tell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you're right, it was merged just after. Right in that case, I think there is nothing that I'm aware of that's breaking in Sumac.