cleanup for howtos3 #638

jesgreco · 2024-12-06T17:31:54Z

cleaning up drag_and_drop_deprecated.rst doc

openedx-webhooks · 2024-12-06T17:31:59Z

Thanks for the pull request, @jesgreco!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/docs-openedx-org-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

jesgreco · 2024-12-06T17:44:06Z

This document seems to be deprecated so, I'm not sure if we need to include them or not @sarina @jswope00

sarina · 2024-12-10T17:55:02Z

Let's stop committing to this branch as it's getting big. Focus on fixing the build errors, please!

jesgreco · 2024-12-10T18:04:43Z

@sarina errors were fixed, you can proceed to merge this PR. Thanks!

source/educators/how-tos/communication/administer_discussions.rst

source/educators/how-tos/course_development/exercise_tools/add_numerical_input_problem.rst

source/educators/how-tos/course_development/library_access.rst

source/educators/how-tos/data/course_answers.rst

source/educators/how-tos/data/manage_course_grades.rst

source/educators/how-tos/drag_and_drop_deprecated.rst

source/educators/how-tos/update_rerun_course.rst

sarina · 2024-12-12T13:58:37Z

source/educators/how-tos/update_rerun_course.rst

@@ -87,10 +87,9 @@ who enroll in the new course run.

  .. only:: Partners


Actually, delete everything under .. only:: Partners, please.

Can you please check the other files in this pull request to see if they have anything specified as .. only:: Partners?

done! I've reviewed the 27 files and no further reference for that.

I think the ".. only::" comment still needs to be deleted, yes?

sarina · 2024-12-12T14:53:30Z

source/educators/navigation/components_activities.rst

@@ -96,7 +96,6 @@ Drag and Drop Problem
   :maxdepth: 2
   :glob:   

-   ../references/course_development/exercise_tools/drag_and_drop.rst


I think you want to keep this in, and delete L104 (the name of the file you deleted)

@jesgreco did you read this comment? it's how you fix the build.

Yes, but still the error is happening.

jesgreco · 2024-12-13T14:31:24Z

@sarina you can proceed to the merge.

sarina

My comments are addressed, but I asked @jswope00 to review this PR as well. John can merge once his review is completed. (John, I suggest you "squash and merge" so we don't have a really long commit history)

jesgreco · 2024-12-13T17:00:21Z

ok, @sarina - I've added one more file since one of it was deleted (the deprecated one).

jswope00 · 2024-12-16T18:24:05Z

source/educators/how-tos/data/manage_course_grades.rst

@@ -251,7 +251,7 @@ The gradebook includes the following features:
  specific graded subsection. For information about how to do this, see
  :ref:`Override in Gradebook`.

-* **Master’s courses:** The edX gradebook has several features for high-touch courses. For learners in the Master’s track:
+* **Master’s courses:** The Open edX gradebook has several features for high-touch courses. For learners in the Master’s track:


agree that references to "Master's courses" should be removed.

jswope00 · 2024-12-16T18:29:01Z

source/educators/how-tos/update_rerun_course.rst

@@ -87,10 +87,9 @@ who enroll in the new course run.

  .. only:: Partners


I think the ".. only::" comment still needs to be deleted, yes?

cleanup for howtos3

8681158

cleaning up drag_and_drop_deprecated.rst doc

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 6, 2024

jesgreco requested review from jswope00, sarina and Apgomeznext December 6, 2024 17:43

jesica-greco-zocdoc added 5 commits December 6, 2024 14:52

cleaning up for adding_mathjax.rst

4233ab1

cleanup for adding_numerical_input_problem.rst

1f2692e

cleaning up for add_text_input.rst doc

2e0b4ae

cleaning up for library_access.rst

98c01f9

cleaning up for add_beta_testers.rst

3863871

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Dec 9, 2024

jesica-greco-zocdoc added 17 commits December 9, 2024 15:33

cleaning up set_licensing.rst

ba9f72b

adjusting and deleting edx ref

0ab2bd9

cleaning up for hide_subsections.rst

e43d1a0

cleaning up for create_hide_delete_sections.rst

ec32768

cleaning up for course_rerun.rst

0d9e9ca

cleaning up for update_rerun_course.rst

807b48e

cleaning up for issuing_certificates.rst

d21f875

cleaning up for view_course_information.rst

97a6b19

cleaning up for manage_course_enrollements.rst

fae4968

cleaning up for manage_course_grades.rst

5995138

cleaning up for course_answers.rst

acc38c9

cleaning up for certificate_data.rst

d274ecc

cleanup for download_or_view_learner_data.rst

c01f180

cleaning up for access_anonymized_data.rst

ddb3f97

cleaning up for send_bulk_email.rst

83fbdcf

cleaning up for review_sent_messages.rst

1ccce91

cleaning up for allow_anonymous_discussions.rst

3b12285

jesica-greco-zocdoc added 6 commits December 10, 2024 14:24

cleaning up for administer_discussions.rst

d7b27ab

adjusting reference

fe4f6d0

cleaning up setup_cohorted_discussions.rst

242ab64

cleaning up for closing_discussions.rst

40b8775

cleaning up for assigning_discussion_roles.rst

e0bfc5a

cleaning up for setting_up_divided_discussions.rst

8beea1d

fixing errors

2ca155b

sarina requested changes Dec 10, 2024

View reviewed changes

jesica-greco-zocdoc and others added 2 commits December 11, 2024 10:42

adjustments asked by Sarina

027b364

Delete source/educators/how-tos/drag_and_drop_deprecated.rst

027ec8e

sarina reviewed Dec 12, 2024

View reviewed changes

jesica-greco-zocdoc added 2 commits December 12, 2024 11:22

deleting edx references

0c11589

fixing error_ToC

9ba844f

sarina reviewed Dec 12, 2024

View reviewed changes

jesica-greco-zocdoc added 5 commits December 12, 2024 13:01

fixing error ToC deleting file

528c5c1

fixing error undeleting file

ab59763

fixing error_tOC

f097184

fixing error ref

76f1c70

changing reference to fix error

c580dcc

jesgreco closed this Dec 13, 2024

jesgreco reopened this Dec 13, 2024

sarina approved these changes Dec 13, 2024

View reviewed changes

export_course.rst

c97dbdb

jswope00 requested changes Dec 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cleanup for howtos3 #638

cleanup for howtos3 #638

jesgreco commented Dec 6, 2024

openedx-webhooks commented Dec 6, 2024

jesgreco commented Dec 6, 2024

sarina commented Dec 10, 2024

jesgreco commented Dec 10, 2024

sarina Dec 12, 2024

jesgreco Dec 12, 2024

jswope00 Dec 16, 2024

sarina Dec 12, 2024 •

edited

Loading

sarina Dec 12, 2024 •

edited

Loading

jesgreco Dec 13, 2024

jesgreco commented Dec 13, 2024

sarina left a comment

jesgreco commented Dec 13, 2024

jswope00 Dec 16, 2024

jswope00 Dec 16, 2024

		@@ -87,10 +87,9 @@ who enroll in the new course run.

		.. only:: Partners

cleanup for howtos3 #638

Are you sure you want to change the base?

cleanup for howtos3 #638

Conversation

jesgreco commented Dec 6, 2024

openedx-webhooks commented Dec 6, 2024

What's next?

🔘 Get product approval

🔘 Provide context

🔘 Get a green build

🔘 Let us know that your PR is ready for review:

Who will review my changes?

Where can I find more information?

When can I expect my changes to be merged?

jesgreco commented Dec 6, 2024

sarina commented Dec 10, 2024

jesgreco commented Dec 10, 2024

sarina Dec 12, 2024

Choose a reason for hiding this comment

jesgreco Dec 12, 2024

Choose a reason for hiding this comment

jswope00 Dec 16, 2024

Choose a reason for hiding this comment

sarina Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

sarina Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

jesgreco Dec 13, 2024

Choose a reason for hiding this comment

jesgreco commented Dec 13, 2024

sarina left a comment

Choose a reason for hiding this comment

jesgreco commented Dec 13, 2024

jswope00 Dec 16, 2024

Choose a reason for hiding this comment

jswope00 Dec 16, 2024

Choose a reason for hiding this comment

sarina Dec 12, 2024 •

edited

Loading

sarina Dec 12, 2024 •

edited

Loading