Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: removed custom pagination for reporting configurations #2292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: removed custom pagination for reporting configurations #2292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ Unreleased
----------
* nothing unreleased

[4.34.0]
--------
* feat: removed custom pagination for reporting configurations.

[4.33.0]
--------
* feat: Updated pagination for reporting configurations.
Expand Down
2 changes: 1 addition & 1 deletion enterprise/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
Your project description goes here.
"""

__version__ = "4.33.0"
__version__ = "4.34.0"
10 changes: 0 additions & 10 deletions enterprise/api/v1/views/enterprise_customer_reporting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from edx_rest_framework_extensions.auth.jwt.authentication import JwtAuthentication
from rest_framework import permissions, status
from rest_framework.authentication import SessionAuthentication
from rest_framework.pagination import PageNumberPagination
from rest_framework.response import Response
from rest_framework.status import HTTP_200_OK, HTTP_404_NOT_FOUND
from rest_framework.views import APIView
Expand All @@ -18,14 +17,6 @@
from enterprise.utils import get_enterprise_customer


class ExpandDefaultPageSize(PageNumberPagination):
"""
Expands page size for the API.
Used to populate large reporting configurations.
"""
page_size = 100


class EnterpriseCustomerReportingConfigurationViewSet(EnterpriseReadWriteModelViewSet):
"""
API views for the ``enterprise-customer-reporting`` API endpoint.
Expand All @@ -35,7 +26,6 @@ class EnterpriseCustomerReportingConfigurationViewSet(EnterpriseReadWriteModelVi
serializer_class = serializers.EnterpriseCustomerReportingConfigurationSerializer
lookup_field = 'uuid'
permission_classes = [permissions.IsAuthenticated]
pagination_class = ExpandDefaultPageSize

USER_ID_FILTER = 'enterprise_customer__enterprise_customer_users__user_id'
FIELDS = (
Expand Down
Loading