Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update meilisearch configuration needed for tags filter [FC-0040] #34534

Conversation

bradenmacdonald
Copy link
Contributor

@bradenmacdonald bradenmacdonald commented Apr 17, 2024

Description

This updates the Meilisearch configuration during index building, so that we can use the "facet search" API on the tags content.

Without this change, we cannot properly get the list of tags to filter by in the (beta) Studio Content Search:
Screenshot 2024-04-17 at 9 49 26 AM

But with this change in place, we can:

Screenshot 2024-04-17 at 9 49 40 AM

Supporting information

Part of openedx/modular-learning#201

This only affects instances that have the MEILISEARCH_ENABLED flag on (default is off).

Testing instructions

To test this, you need to use openedx/frontend-app-authoring#945

Deadline

Neeeded for Redwood, so ASAP

Private ref: FAL-3704

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 17, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bradenmacdonald
Copy link
Contributor Author

@rpenido This PR is ready - could you please review it?

Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bradenmacdonald ! LGTM 👍

  • I tested this on my tutor dev stack using the PR test instructions
  • I read through the code
  • Includes documentation

Also, I added these changes (66b1b71) in the other PR (#34391) in case you merge it first.

@bradenmacdonald
Copy link
Contributor Author

Closing - this was included in another PR ^

@openedx-webhooks
Copy link

@bradenmacdonald Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@bradenmacdonald Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the braden/meilisearch-filter-tags branch April 18, 2024 16:53
@rpenido rpenido restored the braden/meilisearch-filter-tags branch April 19, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants