Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering library by publish status [FC-0062] #1406

Closed

Conversation

bradenmacdonald
Copy link
Contributor

@bradenmacdonald bradenmacdonald commented Oct 19, 2024

Description

Adds a filter widget:

Screenshot 2024-10-18 at 6 02 06 PM

And an "Unpublished changes" badge:

Screenshot 2024-10-18 at 6 02 25 PM

TODO

Get the filter working properly - add a filterable "publish_status" field on the backend Meilisearch index which is set to "published", "modified", or "never". It seems that this is necessary because Meilisearch can filter on things like modified > 23849345 but NOT on things like modified > last_published
Fix i18n
Write tests

@bradenmacdonald bradenmacdonald requested a review from a team as a code owner October 19, 2024 01:02
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 19, 2024
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Oct 21, 2024
@DanielVZ96 DanielVZ96 force-pushed the braden/filter-by-published branch from a68529c to cac19a1 Compare December 13, 2024 21:45
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 74.28571% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.93%. Comparing base (c7e2bf9) to head (cac19a1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/search-manager/FilterByPublished.tsx 65.21% 8 Missing ⚠️
src/search-manager/data/apiHooks.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1406      +/-   ##
==========================================
- Coverage   92.94%   92.93%   -0.01%     
==========================================
  Files        1073     1076       +3     
  Lines       21098    21227     +129     
  Branches     4550     4491      -59     
==========================================
+ Hits        19610    19728     +118     
- Misses       1422     1433      +11     
  Partials       66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bradenmacdonald
Copy link
Contributor Author

Closing in favor of #1570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants