Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove parentLocator and next button from component picker [FC-0062] #1412

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Oct 21, 2024

Description

Removes the need to parentLocator to component picker and removes next button as well. Now when a user selects a library, they are taken to the next page to select components as no other action is required in library selection page.

Supporting information

Testing instructions

Please see openedx/edx-platform#35670

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 21, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 21, 2024

Thanks for the pull request, @navinkarkera!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.12%. Comparing base (56e025a) to head (76e5c14).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   93.12%   93.12%   -0.01%     
==========================================
  Files        1050     1050              
  Lines       20140    20132       -8     
  Branches     4204     4272      +68     
==========================================
- Hits        18755    18747       -8     
+ Misses       1325     1322       -3     
- Partials       60       63       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navinkarkera navinkarkera changed the title refactor: remove parentLocator from component picker refactor: remove parentLocator and next button from component picker Oct 21, 2024
Jump to component selection on library selection
@navinkarkera navinkarkera force-pushed the navin/refactor-picker-v2 branch from 4fe7e27 to 76e5c14 Compare October 21, 2024 05:53
@navinkarkera navinkarkera marked this pull request as ready for review October 21, 2024 06:08
@navinkarkera navinkarkera requested a review from a team as a code owner October 21, 2024 06:08
@navinkarkera navinkarkera changed the title refactor: remove parentLocator and next button from component picker refactor: remove parentLocator and next button from component picker [FC-0062] Oct 21, 2024
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and code looks good! Just asked on Slack about removing the "Next" step

@bradenmacdonald bradenmacdonald merged commit d49fc85 into openedx:master Oct 21, 2024
8 checks passed
@bradenmacdonald bradenmacdonald deleted the navin/refactor-picker-v2 branch October 21, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants