feat: plugin slots for video and file upload components and alerts #1523
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @xitij2000! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
xitij2000
force-pushed
the
kshitij/plugin-slots/files-and-alerts
branch
from
d1a51a4 to
694edb1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1523 +/- ##
=======================================
Coverage 92.96% 92.97%
=======================================
Files 1075 1079 +4
Lines 21190 21211 +21
Branches 4554 4482 -72
=======================================
+ Hits 19700 19721 +21
Misses 1424 1424
Partials 66 66 ☔ View full report in Codecov by Sentry. |
| errors: errorMessages, | ||
| } = useSelector(state => state.assets); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Some spacing between the different hooks would make it more readable.
This change add plugin slots for the file and video upload components, and the alerts components on those pages.
xitij2000
force-pushed
the
kshitij/plugin-slots/files-and-alerts
branch
from
a49f0b4 to
4e9d9df
Compare
Description
This change adds plugin slots for the file and video upload pages to allow developers to customise those components. It also adds empty slots allowing developers to add additional alerts.
Supporting information
NA
Testing instructions
TBD
Other information
This change is being made to support a feature where a client wants course authors to acknowledge fair use terms before they are allowed to upload files