fix: Show published OLX in Library Content Picker [FC-0062] #1534
Conversation
|
Thanks for the pull request, @ChrisChV! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
ChrisChV
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1534 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 1065 1065
Lines 20980 20981 +1
Branches 4468 4468
=======================================
+ Hits 19494 19495 +1
Misses 1419 1419
Partials 67 67 ☔ View full report in Codecov by Sentry. |
| @@ -418,8 +418,8 @@ export async function createCollection(libraryId: string, collectionData: Create | |||
| * Fetch the OLX for the given XBlock. | |||
| */ | |||
| // istanbul ignore next | |||
| export async function getXBlockOLX(usageKey: string): Promise<string> { | |||
| const { data } = await getAuthenticatedHttpClient().get(getXBlockOLXApiUrl(usageKey)); | |||
| export async function getXBlockOLX(usageKey: string, version?: string): Promise<string> { | |||
There was a problem hiding this comment.
Instead of version?: string maybe we can use version?: VersionSpec ?
| @@ -350,10 +350,10 @@ export const useCreateLibraryCollection = (libraryId: string) => { | |||
| }; | |||
|
|
|||
| /** Get the OLX source of a library component */ | |||
| export const useXBlockOLX = (usageKey: string) => ( | |||
| export const useXBlockOLX = (usageKey: string, version?: string) => ( | |||
There was a problem hiding this comment.
Instead of version?: string maybe we can use version?: VersionSpec ?
| render(usageKey, undefined, true); | ||
| const expandButton = await screen.findByRole('button', { name: /Advanced details/ }); | ||
| fireEvent.click(expandButton); | ||
| // Because of syntax highlighting, the OLX will be borken up by many different tags so we need to search for |
There was a problem hiding this comment.
| // Because of syntax highlighting, the OLX will be borken up by many different tags so we need to search for | |
| // Because of syntax highlighting, the OLX will be broken up by many different tags so we need to search for |
Description
Fix #1354 (comment)
Supporting information
GitHub Issue: #1354 (comment)
Depends on: openedx/edx-platform#35932
Internal ticket: FAL-3976
Testing instructions
Details → Advanced details → OLX Sourceand verify that you can see the published OLX.