-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add taxonomies tab in home page #923
feat: Add taxonomies tab in home page #923
Conversation
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
9f0f99e
to
a2254b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #923 +/- ##
=======================================
Coverage 91.93% 91.93%
=======================================
Files 571 571
Lines 10179 10183 +4
Branches 2205 2206 +1
=======================================
+ Hits 9358 9362 +4
Misses 794 794
Partials 27 27 ☔ View full report in Codecov by Sentry. |
65ec17b
to
e368e1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yusuf-musleh Looks good, only one minor nit 👍
- I tested this: I followed the testing instructions.
- I read through the code and considered the security, stability and performance implications of the changes.
- I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
- Includes tests for bugfixes and/or features added.
e368e1c
to
0d1c6b7
Compare
@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@yusuf-musleh I have recently pulled the most recent version of master which includes this work and the taxonomy tab is appearing for me even though I do not have taxonomies set up in my environment. Can you create a new PR that makes sure that the tab does not appear unless taxonomies is set up? |
@KristinAoki Sure thing, I'll look into it and create a new PR for that. |
Description
This PR adds a "Taxonomies" tab to the course authoring home page, and redirects to the taxonomies page when clicked.
Testing instructions
new_studio_mfe.use_new_home_page
flag is enabledPrivate-ref: FAL-3699