Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add taxonomies tab in home page #923

Merged

Conversation

yusuf-musleh
Copy link
Member

Description

This PR adds a "Taxonomies" tab to the course authoring home page, and redirects to the taxonomies page when clicked.

Screenshot 2024-03-28 at 12 26 54 PM

Testing instructions

  1. Run this branch in your local dev stack
  2. Make sure you have the new_studio_mfe.use_new_home_page flag is enabled
  3. Navigate to the course authoring home page: http://apps.local.edly.io:2001/course-authoring/home
  4. Confirm that the taxonomies tab appears, as in the screenshot
  5. Confirm that clicking on it navigates to the taxonomies list page

Private-ref: FAL-3699

@yusuf-musleh yusuf-musleh requested a review from a team as a code owner March 28, 2024 09:31
@openedx-webhooks
Copy link

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 28, 2024
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/add-taxonomies-tab branch from 9f0f99e to a2254b9 Compare March 28, 2024 09:37
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (d44edb8) to head (0d1c6b7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files         571      571           
  Lines       10179    10183    +4     
  Branches     2205     2206    +1     
=======================================
+ Hits         9358     9362    +4     
  Misses        794      794           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/add-taxonomies-tab branch 13 times, most recently from 65ec17b to e368e1c Compare March 29, 2024 13:21
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusuf-musleh Looks good, only one minor nit 👍

  • I tested this: I followed the testing instructions.
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
  • Includes tests for bugfixes and/or features added.

src/studio-home/tabs-section/messages.js Show resolved Hide resolved
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/add-taxonomies-tab branch from e368e1c to 0d1c6b7 Compare April 1, 2024 23:53
@xitij2000 xitij2000 merged commit 806591f into openedx:master Apr 4, 2024
6 checks passed
@openedx-webhooks
Copy link

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000 xitij2000 deleted the yusuf-musleh/add-taxonomies-tab branch April 4, 2024 12:04
@KristinAoki
Copy link
Member

@yusuf-musleh I have recently pulled the most recent version of master which includes this work and the taxonomy tab is appearing for me even though I do not have taxonomies set up in my environment. Can you create a new PR that makes sure that the tab does not appear unless taxonomies is set up?

@yusuf-musleh
Copy link
Member Author

@KristinAoki Sure thing, I'll look into it and create a new PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants