Skip to content

Commit

Permalink
fix: remove purgecss (#440)
Browse files Browse the repository at this point in the history
PurgeCSS doesn’t work with the latest version of PostCSS, far as I can tell.  It ends up removing too many classes.  It has always been sort of problematic and we only use it in a few MFEs, so I think it’s time for it to go.
  • Loading branch information
davidjoy authored Jul 13, 2021
1 parent 242a03e commit f06bea9
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 72 deletions.
7 changes: 0 additions & 7 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,6 @@ This MFE is configured via node environment variables supplied at build time. Se
For more information see the document: `Micro-frontend applications in Open
edX <https://edx.readthedocs.io/projects/edx-developer-docs/en/latest/micro-frontends-in-open-edx.html>`__.

----------

Notes
-----

The production Webpack configuration for this repo uses `Purgecss <https://www.purgecss.com/>`__ to remove unused CSS from the production css file. In ``webpack.prod.config.js`` the Purgecss plugin is configured to scan directories to determine what css selectors should remain. Currently the src/ directory is scanned along with all ``@edx/frontend-component*`` node modules and ``@edx/paragon``. **If you add and use a component in this repo that relies on HTML classes or ids for styling you must add it to the Purgecss configuration or it will be unstyled in the production build.**

.. |Build Status| image:: https://api.travis-ci.org/edx/frontend-app-profile.svg?branch=master
:target: https://travis-ci.org/edx/frontend-app-profile
.. |Codecov| image:: https://img.shields.io/codecov/c/github/edx/frontend-app-profile
Expand Down
43 changes: 0 additions & 43 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"es-check": "5.2.4",
"glob": "7.1.7",
"husky": "6.0.0",
"purgecss-webpack-plugin": "4.0.3",
"react-test-renderer": "16.14.0",
"reactifex": "1.1.1",
"redux-mock-store": "1.5.4"
Expand Down
21 changes: 0 additions & 21 deletions webpack.prod.config.js

This file was deleted.

0 comments on commit f06bea9

Please sign in to comment.