Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make raw string a formatted message #1041

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

CodeWithEmad
Copy link
Member

@CodeWithEmad CodeWithEmad commented Jun 21, 2024

Before this, the "Your profile cannot be shared." sentence was hardcoded and not translated.
@openedx/2u-aperture kindly have a look.

Close #1040

before this, the "Your profile cannot be shared." sentence couldn't be
translated and it was hardcoded.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 21, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@CodeWithEmad
Copy link
Member Author

@jsnwesson Should someone add the key to transifex?

@jsnwesson
Copy link
Contributor

@CodeWithEmad that I'm not too certain of because our team no longer maintains the translations for the Profile MFE (or really any MFE/app that is under the openedx org. Since translations are now handled by AXIM, I think they'd know if there's any further actions needed. @brian-smith-tcril , thoughts?

@brian-smith-tcril
Copy link
Contributor

This should get picked up automatically the next time the extract-translation-source-files workflow runs after this is merged. There is no need to manually add keys to transifex.

@jsnwesson jsnwesson merged commit 6aaf615 into openedx:master Jun 24, 2024
7 checks passed
@openedx-webhooks
Copy link

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@CodeWithEmad CodeWithEmad deleted the fix/untranslated branch June 24, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

Unformatted message
4 participants