fix: fixed responsiveness issues on mobile view #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemaanamir
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2u-main #1133 +/- ##
===========================================
+ Coverage 67.12% 69.25% +2.12%
===========================================
Files 51 72 +21
Lines 864 1210 +346
Branches 177 272 +95
===========================================
+ Hits 580 838 +258
- Misses 274 357 +83
- Partials 10 15 +5 ☔ View full report in Codecov by Sentry. |
AhtishamShahid
approved these changes
Nov 22, 2024
sundasnoreen12
requested changes
Nov 22, 2024
Comment on lines
+61
to
+65
| <p className={classNames([ | ||
| 'm-0 color-black', | ||
| isMobileView ? 'h5' : 'h4', | ||
| ])} | ||
| > |
There was a problem hiding this comment.
use this <p className={classNames('m-0 color-black', {
'h5': isMobileView,
'h4': !isMobileView,
})}>
Comment on lines
+79
to
+83
| <p className={classNames([ | ||
| 'mb-0', | ||
| isMobileView ? 'x-small' : 'small', | ||
| ])} | ||
| > |
Comment on lines
+19
to
+22
| <p className={classNames([ | ||
| 'font-weight-bold text-primary-500 m-0', | ||
| isMobileView ? 'h3' : 'h2', | ||
| ])} |
There was a problem hiding this comment.
follow above pattern for classNames and change wherever used
| </p> | ||
| ); | ||
| const UsernameDescription = () => { | ||
| const isMobileView = useWindowSize().width <= breakpoints.small.minWidth; |
sundasnoreen12
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: INF-1708
Fixed responsiveness issues on mobile and tablet views.
Laptop View 1440px:
Laptop View 1024px:
Tablet View 768px:
Mobile View 425px:
Mobile View 375px:
Mobile View 320px: