fix: Downgrading image-webpack-loader to fix linux arch bug in gifsicle #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
approved these changes
Dec 17, 2020
mikix
approved these changes
Dec 17, 2020
davidjoy
force-pushed
the
djoy/downgrade_image-webpack-loader_6.0.0
branch
from
c766356
to
8e6073d
Compare
davidjoy
changed the title
There’s a documented issue in “imagemin-gifsicle” where a recent update (5.0.0) removed the binaries for linux distributions: imagemin/gifsicle-bin#113 This causes it to explode in CI via our direct dependency on image-webpack-loader. The 7.0.0 version of image-webpack-loader relies on version 5 of gifsicle. If we downgrade back to 6.0.0, we get gifsicle 4.0.1 instead, which still has the binaries.
davidjoy
force-pushed
the
djoy/downgrade_image-webpack-loader_6.0.0
branch
from
8e6073d
to
4cfae09
Compare
|
🎉 This PR is included in version 5.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s a documented issue in “imagemin-gifsicle” where a recent update (5.0.0) removed the binaries for linux distributions:
imagemin/gifsicle-bin#113
tcoopman/image-webpack-loader#233
This causes it to explode in CI via our direct dependency on image-webpack-loader. The 7.0.0 version of image-webpack-loader relies on version 5 of gifsicle. If we downgrade back to 6.0.0, we get gifsicle 4.0.1 instead, which still has the binaries.
I'm also noticing that the source for gifsicle is a bit confusing. There's two projects here:
https://github.com/imagemin/imagemin-gifsicle
https://github.com/imagemin/gifsicle-bin
gifsicle-bin is the one that needs to be downgraded to 4.0.1 from 5.0.0. imagemin-gifsicle also gets downgraded from 7.0.0 to 6.0.1 in the process, and appears to be the direct dependency of image-webpack-loader.
Confusing, but I think this will fix our pipelines.