-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor extract command with its tests #135
feat: refactor extract command with its tests #135
Conversation
Refactor for more usability and readability. And to prepare tests to deal with options to be added to extract command in future pull-requests Refs: FC-0012 OEP-58
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
This one is ready @OmarIthawi , @brian-smith-tcril |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 99.47% 99.74% +0.27%
==========================================
Files 10 10
Lines 381 399 +18
Branches 28 27 -1
==========================================
+ Hits 379 398 +19
+ Partials 2 1 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @shadinaif!!
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Refactor for more usability and readability. And to prepare tests to deal with options to be added to
extract
command in future pull-requestsrun
method into a separate method namedbabel_extract
TestExtract
to avoid calling the mockedextract
command unless it's needed. Doing that by creating a decorator namedperform_extract
Change log?
None, just a code refactor