Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standard workflow files. #25

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Feb 23, 2023

This PR was created automatically by the repo_checks.py script in the
https://github.com/openedx/terraform-github repository.

Feanil Patel added 2 commits February 23, 2023 11:04
The .github/workflows/self-assign-issue.yml workflow is missing or needs an update to stay in
sync with the current standard for this workflow as defined in the
`.github` repo of the `openedx` GitHub org.
…d.yml`.

The .github/workflows/add-depr-ticket-to-depr-board.yml workflow is missing or needs an update to stay in
sync with the current standard for this workflow as defined in the
`.github` repo of the `openedx` GitHub org.

jobs:
commitlint:
uses: openedx/.github/.github/workflows/commitlint.yml@master

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feanil, @e0d, looks like the addition of the commitlint.yml is now making CI fail. Not knowing much about Backstage, I don't know whether to recomend ditching the check for this repo, or if it's actually applicable here, to fix it so it works.

@feanil
Copy link
Contributor Author

feanil commented Feb 28, 2023

Looks like this is an issue with the commitlint CLI, and currently there is no fix in the github action we're using...

conventional-changelog/commitlint#3256

wagoid/commitlint-github-action#560

I'm gonna drop that workflow from this PR and land the rest, we can leave the PR open for the other one until the upstream issues are resolved.

…yml`.

The .github/workflows/add-remove-label-on-comment.yml workflow is missing or needs an update to stay in
sync with the current standard for this workflow as defined in the
`.github` repo of the `openedx` GitHub org.
@feanil feanil force-pushed the repo_checks/ensure_workflows branch from 64994e1 to 7d2e563 Compare February 28, 2023 16:37
@feanil feanil requested a review from arbrandes February 28, 2023 16:37
@arbrandes arbrandes merged commit 47849bf into main Feb 28, 2023
@arbrandes arbrandes deleted the repo_checks/ensure_workflows branch February 28, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants