Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent soft-deletes from being re-published every time #211

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ormsbee
Copy link
Contributor

@ormsbee ormsbee commented Aug 14, 2024

Details are in a comment from this change:

        # Account for soft-deletes:
        # NULL != NULL in SQL, so simply excluding entities where the Draft
        # and Published versions match will not catch the case where a
        # soft-delete has been published (i.e. both the Draft and Published
        # versions are NULL). We need to explicitly check for that case
        # instead, or else we will re-publish the same soft-deletes over
        # and over again.

@ormsbee ormsbee changed the title fix soft delete republish fix: prevent soft-deletes from being re-published every time Aug 14, 2024
@ormsbee ormsbee force-pushed the fix-soft-delete-republish branch 2 times, most recently from 624acce to 6699388 Compare August 14, 2024 20:13
@ormsbee
Copy link
Contributor Author

ormsbee commented Aug 15, 2024

@pomegranited or @navinkarkera: Review if one of you has time, please?

Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ormsbee Looks good. 👍

  • I tested this: Published library with soft deleted components and verified that they are not included in the publish log records.
  • I read through the code
  • Includes documentation

@ormsbee ormsbee merged commit eb34c15 into openedx:main Aug 16, 2024
9 checks passed
@ormsbee ormsbee deleted the fix-soft-delete-republish branch August 16, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants