Remove Django 3.2 collations compatibility hack #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the collation via Field db_parameters was not properly supported before Django 4.x. We worked around this with a Django 3.2-compatible hack in 084ec21. Now that we require at least Django 4.2, we no longer need the compatibility hack.
kdmccormick
approved these changes
Aug 16, 2024
|
It's stupid, but I'm irrationally fond of the hack that I'm removing here. I mean, the hack is absolutely terrible and we're definitely better off getting rid of it, but it worked surprisingly well. 😛 |
|
Yeah, OOP and getter/setter magic can drive me crazy but this is a good demonstration of when it's really helpful 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the collation via Field db_parameters was not properly supported before Django 4.x. We worked around this with a Django 3.2-compatible hack in ormsbee@084ec21. Now that we require at least Django 4.2, we no longer need the compatibility hack.