Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Albany general #128

Merged
merged 2 commits into from
Jan 1, 2023
Merged

added Albany general #128

merged 2 commits into from
Jan 1, 2023

Conversation

kdent
Copy link
Contributor

@kdent kdent commented Jan 1, 2023

This is my first contribution, so let me know if you have any comments or feedback on it. Meanwhile, I keep going onto other counties.

@dwillis
Copy link
Contributor

dwillis commented Jan 1, 2023

@kdent thank you so much, this is great. A couple of small things:

  1. Column names should be lower cased
  2. The office values should match the list in the issue (2022 General Election Official Precinct Results Conversion #127), which means that the office values should not contain the district number.

Let me know if you're able to make those changes and will be happy to accept this.

@kdent
Copy link
Contributor Author

kdent commented Jan 1, 2023

Got it. No problem, I just committed a new version with those fixes.

@dwillis dwillis merged commit a2f89ad into openelections:master Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants