Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Clean up repo #53

Merged
merged 25 commits into from
Nov 26, 2018
Merged

Clean up repo #53

merged 25 commits into from
Nov 26, 2018

Conversation

amaury1093
Copy link
Collaborator

@amaury1093 amaury1093 commented Nov 23, 2018

  • Bump all packages to 3.0.0
  • All packages now require local packages. Which means when we modify one, all the other immediately know of the changes.
  • added back the old api folder, because all tests pass there. That's most of the file changes in the file diff.
    • to run those tests: yarn test:api in root folder, or yarn test in api folder
  • in api, only converted utils/ and format/ folder to TS (related Convert @parity/api to TypeScript #21)
  • fix Metamask responses are not parsed #48 correctly

Edit: to test in real life: cd packages/light.js/example && yarn start, uses (almost) all packages, works with metamask and with local node.

@@ -20,7 +20,9 @@
"scripts": {
"build": "lerna exec yarn build --stream",
"lint": "tslint 'packages/**/*.ts'",
"postinstall": "yarn build",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this, so that when people clone this repo and install, all the packages are built.

@coveralls
Copy link

coveralls commented Nov 23, 2018

Pull Request Test Coverage Report for Build 256

  • 230 of 306 (75.16%) changed or added relevant lines in 15 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+22.5%) to 74.919%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/api/src/util/encode.ts 4 5 80.0%
packages/light.js/src/rpc/utils/createRpc.ts 2 3 66.67%
packages/api/src/format/input.ts 45 53 84.91%
packages/api/src/format/output.ts 149 215 69.3%
Files with Coverage Reduction New Missed Lines %
packages/electron/src/getParityPath.ts 1 0.0%
packages/electron/src/fetchParity.ts 1 0.0%
packages/contracts/src/badgereg.ts 3 0.0%
Totals Coverage Status
Change from base Build 247: 22.5%
Covered Lines: 1335
Relevant Lines: 1791

💛 - Coveralls

Copy link
Contributor

@axelchalon axelchalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@amaury1093 amaury1093 merged commit a9fc6d5 into master Nov 26, 2018
@amaury1093 amaury1093 deleted the am-api branch November 26, 2018 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metamask responses are not parsed
3 participants