This repository has been archived by the owner on May 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
commented
Nov 23, 2018
@@ -20,7 +20,9 @@ | |||
"scripts": { | |||
"build": "lerna exec yarn build --stream", | |||
"lint": "tslint 'packages/**/*.ts'", | |||
"postinstall": "yarn build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this, so that when people clone this repo and install, all the packages are built.
Pull Request Test Coverage Report for Build 256
💛 - Coveralls |
axelchalon
approved these changes
Nov 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn test:api
in root folder, oryarn test
in api folderapi
, only convertedutils/
andformat/
folder to TS (related Convert @parity/api to TypeScript #21)Edit: to test in real life:
cd packages/light.js/example && yarn start
, uses (almost) all packages, works with metamask and with local node.