Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for using contextual tuples in Expand API #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sujitha-av
Copy link
Contributor

@sujitha-av sujitha-av commented Oct 27, 2024

Description

Adds documentation on use of contextual tuples with Expand API

References

#951 in openfga

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected.

@sujitha-av sujitha-av requested review from a team as code owners October 27, 2024 12:44
Copy link

linux-foundation-easycla bot commented Oct 27, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sujitha-av / name: Sujitha A V (b5e432b)

@miparnisari
Copy link
Member

@sujitha-av please git merge origin/main

@@ -390,6 +391,116 @@ service OpenFGAService {
"}\n"
"```\n"
"The caller can then call expand API for the `writer` relationship for the `document:2021-budget`."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"The caller can then call expand API for the `writer` relationship for the `document:2021-budget`."
"The caller can then call expand API for the `writer` relationship for the `document:2021-budget`.\n"

otherwise, formatting is incorrect:

image

" \"object\": \"folder:1\",\n"
" \"relation\": \"owner\"\n"
" },\n"
" \"authorization_model_id\": \"model_id\"\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line

" }\n"
" ]\n"
" },\n"
" \"authorization_model_id\": \"model_id\"\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line

@sujitha-av
Copy link
Contributor Author

Is a separate documentation PR needed for openfga.dev? As far as I checked there is not particular documentation for usage of contextual tuples with each of the request types. I can proceed if it is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants