Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrating server tests #304

Merged
merged 1 commit into from
Aug 6, 2024
Merged

chore: migrating server tests #304

merged 1 commit into from
Aug 6, 2024

Conversation

d-jeffery
Copy link
Contributor

@d-jeffery d-jeffery commented Jul 29, 2024 •
edited
Loading

Description

  • Added tests from API
    • Cycle tests are currently skipped
  • Fix InvalidType exception when type & relation name. InvalidType now only marks the type on the right side of a relation definition
  • refactor hasEntryPointOrLoop to return objects, not arrays

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery force-pushed the chore/migrate-server-tests branch 4 times, most recently from 6fa42c0 to 786959d Compare August 5, 2024 22:27
@d-jeffery d-jeffery marked this pull request as ready for review August 5, 2024 22:34
@d-jeffery d-jeffery requested review from a team as code owners August 5, 2024 22:34
@d-jeffery d-jeffery force-pushed the chore/migrate-server-tests branch 2 times, most recently from 5b0e865 to a1a48a9 Compare August 6, 2024 15:11
rhamzeh
rhamzeh reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate more on:

Commented out tests with discrepancies

I see no commented out tests

@d-jeffery
Copy link
Contributor Author

Can you elaborate more on:

Commented out tests with discrepancies

I see no commented out tests

Sorry - was a comment left over before I tagged the cycle tests with skip

@d-jeffery d-jeffery requested a review from rhamzeh August 6, 2024 16:55
@d-jeffery d-jeffery added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit ca86c23 Aug 6, 2024
18 checks passed
@d-jeffery d-jeffery deleted the chore/migrate-server-tests branch August 6, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

@ewanharris ewanharris Awaiting requested review from ewanharris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-jeffery @rhamzeh