Memory leak fix in curl bindings

[trnzk]

No description provided.

[dimensionscape]

Yeah this makes sense. Thanks!

[trnzk]

Issue 2313 might be related to this.

[barisyild]

Issue 2313 might be related to this.

@trnzk Unfortunately there is a leak in the png implementation :(

I took this image from my 5 minute game session.

The functions that cause leakage are as follows;

lime/project/src/graphics/format/PNG.cpp

Line 296 in 3d10ea7

png_write_rows (png_ptr, &row, 1);

lime/project/src/graphics/format/PNG.cpp

Line 228 in 3d10ea7

png_structp png_ptr = png_create_write_struct (PNG_LIBPNG_VER_STRING, NULL, user_error_fn, user_warning_fn);

lime/project/src/graphics/format/PNG.cpp

Line 236 in 3d10ea7

png_infop info_ptr = png_create_info_struct (png_ptr);

[barisyild]

Issue 2313 might be related to this.

@trnzk Unfortunately there is a leak in the png implementation :(

I took this image from my 5 minute game session.

The functions that cause leakage are as follows;

lime/project/src/graphics/format/PNG.cpp

Line 296 in 3d10ea7

png_write_rows (png_ptr, &row, 1);

lime/project/src/graphics/format/PNG.cpp

Line 228 in 3d10ea7

png_structp png_ptr = png_create_write_struct (PNG_LIBPNG_VER_STRING, NULL, user_error_fn, user_warning_fn);

lime/project/src/graphics/format/PNG.cpp

Line 236 in 3d10ea7

png_infop info_ptr = png_create_info_struct (png_ptr);

Sorry for misinformation, this leak is related to png encode, probably curl fix will fix the leak mentioned.

[barisyild]

_ No description provided. _

My tests still confirm a memory leak.

lime::header_callback(void*, unsigned long, unsigned long, void*)
chop_write
Curl_client_write
Curl_http_readwrite_headers
readwrite_data
Curl_readwrite
multi_runsingle
curl_multi_perform
lime::lime_curl_multi_perform(_value*)
lime::net::curl::CURLMulti_obj::perform()

[barisyild]

_ No description provided. _

My tests still confirm a memory leak.

lime::header_callback(void*, unsigned long, unsigned long, void*) chop_write Curl_client_write Curl_http_readwrite_headers readwrite_data Curl_readwrite multi_runsingle curl_multi_perform lime::lime_curl_multi_perform(_value*) lime::net::curl::CURLMulti_obj::perform()

Please remove following lines to fix memory leak.

lime/project/src/net/curl/CURLBindings.cpp

Line 599 in 190d1d3

values->clear ();

lime/project/src/net/curl/CURLBindings.cpp

Line 706 in 190d1d3

values->clear ();

[trnzk]

Removing these lines will change the purpose of the function; it would be more appropriate to use the free_header_values function before 'clear'. I don’t have the opportunity to test it right now, but if you try it this way and let me know the result, I’d appreciate it.

[barisyild]

Removing these lines will change the purpose of the function; it would be more appropriate to use the free_header_values function before 'clear'. I don’t have the opportunity to test it right now, but if you try it this way and let me know the result, I’d appreciate it.

Changing these lines does not affect the purpose or behavior of the function, in fact it creates the behavior it should have.

If you empty the vector, the free_header_values function is useless because it always tries to freeing the empty vector.

also writing free under alloc_string doesn't work because alloc_string is just casting and the same pointer will still be used.