-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Changing styles of buttons in Questions Page. #459
Conversation
I'm not sure about what was expected from this issue, maybe better to clarify what has to be done before writing the PR. A screenshot is not an issue, since we can not know if it's the goal or if it highlights a bug. Maybe @teolemon will have more feedback |
The linked issue is a bit poorly formulated, indeed, but I think these buttons look better than the current buttons, at least. The current buttons are way too big. I don't see the point of that circular highlight on the skip button, though. |
That's fair. I was think about desktop. The buttons are simply ginourmous. I want to make more space for the image by shrinking them, as I outline in my discussion post #463 |
@alexfauquette initially the buttons were aligned like this: But as mentioned in issue #251, it was asked to align the buttons in a more compact manner. So working on it, the following is the way of how the buttons are now placed in: Wide Screen View (Computer):Mobile View: |
In the issue, it's a screenshot taken by @teolemon (not a figma design) So I assume it was the initial design when I put 3 buttons to do the job without thinking about how they should be placed. on desktop, I agree it's an improvement to save some vertical place to allow the image to be more visible 👍 on mobile I tend to disagree it's an improvement for two reasons:
|
I agree, stacking them all vertically on mobile is a mistake. |
What
Screenshot