Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changing styles of buttons in Questions Page. #459

Closed
wants to merge 2 commits into from

Conversation

Apurv428
Copy link

@Apurv428 Apurv428 commented Jan 5, 2023

What

Screenshot

Screenshot (23)

@Apurv428 Apurv428 requested a review from a team as a code owner January 5, 2023 10:47
@Apurv428 Apurv428 changed the title fix: fix: Changing styles of buttons in Questions Page. Jan 5, 2023
@alexfauquette
Copy link
Member

I'm not sure about what was expected from this issue, maybe better to clarify what has to be done before writing the PR.

A screenshot is not an issue, since we can not know if it's the goal or if it highlights a bug. Maybe @teolemon will have more feedback

@braaar
Copy link

braaar commented Jan 6, 2023

The linked issue is a bit poorly formulated, indeed, but I think these buttons look better than the current buttons, at least. The current buttons are way too big. I don't see the point of that circular highlight on the skip button, though.

@alexfauquette
Copy link
Member

current buttons are way too big

Even on mobile? I tend to prefer big button on mobile to be sure to do not miss click

image

@braaar
Copy link

braaar commented Jan 6, 2023

current buttons are way too big

Even on mobile? I tend to prefer big button on mobile to be sure to do not miss click

That's fair. I was think about desktop. The buttons are simply ginourmous. I want to make more space for the image by shrinking them, as I outline in my discussion post #463

@Apurv428
Copy link
Author

Apurv428 commented Jan 7, 2023

@alexfauquette initially the buttons were aligned like this:
Screenshot_20230107_112209

But as mentioned in issue #251, it was asked to align the buttons in a more compact manner. So working on it, the following is the way of how the buttons are now placed in:

Wide Screen View (Computer):

Screenshot_20230107_112645

Mobile View:

Screenshot_20230107_112705

@alexfauquette
Copy link
Member

In the issue, it's a screenshot taken by @teolemon (not a figma design) So I assume it was the initial design when I put 3 buttons to do the job without thinking about how they should be placed.

on desktop, I agree it's an improvement to save some vertical place to allow the image to be more visible 👍

on mobile I tend to disagree it's an improvement for two reasons:

  1. The previous one is more compact and on mobile, it's even more critical to save space for the image. The initial idea behind hunger-games is to allow contributors to annotate products instead of scrolling Twitter in the train (mobile first).
  2. The previous one is more semantic: Your thumb is up ready to answer: left or right depending on yes or no, bottom if you don't know. Yes or No are similar (you answer the question) and distinct from skip. When I play I gave me 2 seconds to press left or right. If I have a doubt I skip

@braaar
Copy link

braaar commented Jan 10, 2023

I agree, stacking them all vertically on mobile is a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants