Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: capitalise country name. #522

Merged
merged 5 commits into from
Feb 5, 2023

Conversation

Sudhanva-Nadiger
Copy link
Contributor

@Sudhanva-Nadiger Sudhanva-Nadiger commented Feb 1, 2023

What

  • Capitalise country name while showing

Screenshot

image

image

Fixes bug(s)

Part of

@alexfauquette
Copy link
Member

Nice, could you also apply it to the eco score page?
https://hunger.openfoodfacts.org/eco-score

@Sudhanva-Nadiger
Copy link
Contributor Author

Sudhanva-Nadiger commented Feb 1, 2023

So this is all capitalisation we wanted ?? 😁

Yupp i will do that😁

- Impacted Files :
    - `src/components/QuestionFilter/QuestionFilter.jsx`
    - `src/pages/eco-score/index.jsx`
    - `src/pages/questions/ProductInformation.jsx`
    - `src/utils.js`

- Added the function for capitalising names to utils to use it wherever
we need.
- Changed display of country names in details(ProductInformation).
src/utils.js Outdated Show resolved Hide resolved
@alexfauquette alexfauquette merged commit 56f5a40 into openfoodfacts:master Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants