refactor(Price add): On barcode manual input, show result confirmation before send #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty cool ! Small detail, this seems to break pre-filling the barcode value. At a glance, it looks like there is a mismatch in variables names, but I haven't tested if that's the only issue.
|
11 tasks
ahh you're right, i renamed the props but not quite everywhere 👀 |
raphodn
added a commit
that referenced
this pull request
Dec 10, 2024
raphodn
added a commit
that referenced
this pull request
Dec 11, 2024
raphodn
added a commit
that referenced
this pull request
Dec 12, 2024
raphodn
added a commit
that referenced
this pull request
Dec 12, 2024
TTalex
added a commit
that referenced
this pull request
Dec 12, 2024
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Following #1102 where we merged the barcode scan & manual input in 1 single dialog.
Changes:
Following feedback in #1085
Screenshot