feat(proof): recent proof dialog: add load more button, filter list depending on receipt or price tag #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
reviewed
May 27, 2024
| @@ -33,7 +38,8 @@ export default { | |||
| return { | |||
| userProofList: [], | |||
| userProofTotal: null, | |||
| userProofPage: 1, | |||
| userProofPage: 0, | |||
| userProofType: this.$route.path.endsWith('/receipt') ? 'RECEIPT' : 'PRICE_TAG', | |||
There was a problem hiding this comment.
the issue here is that the component's behavior will rely on the url. it would be better to be an optional parameter (props)
for example this component is used in the AddPriceSingle. but we shouldn't filter proofs there.
There was a problem hiding this comment.
Nice, thanks! 👍
However, if I'm understanding it correctly now that this filter is in place, the 'add a price' button on a specific proof id page with the RECEIPT type won't show the selected proof in the recent proofs dialog box on the add price page anymore. That could maybe be resolved by combining all the 'add price' pages into the add multiple page instead and add a proof type selector on the page to choose between price tag and receipt?
raphodn
approved these changes
May 27, 2024
raphodn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Also, filters the proof type when fetching proofs based on if you're adding receipts or regular price tags.
Screenshot
Fixes bug(s)
Part of