fix: make NOVA panel clearer #6833
Conversation
github-actions
bot
added
📖 Knowledge Panels
|
Kudos, SonarCloud Quality Gate passed!
|
| <li>[% lang('attribute_nova_2_description_short') %]</li> | ||
| <li>[% lang('attribute_nova_3_description_short') %]</li> | ||
| <li>[% lang('attribute_nova_4_description_short') %]</li> | ||
| <li>[% IF nova_group == 1 %]<b>[% END %][% lang('attribute_nova_1_description_short') %][% IF nova_group == 1 %]</b>[% END %]</li> |
There was a problem hiding this comment.
We can use a style, it will be cleaner and will halve the number of IF conditions.
| @@ -35,6 +35,8 @@ | |||
| [% END %] | |||
| [% END %] | |||
| [% END %] | |||
| <br> | |||
There was a problem hiding this comment.
Adding <br> at the end of panels is probably not the right way, clients should decide how much spaces to leave.
|
Good idea to bold the explanantion for the product NOVA group. It probably makes sense to invert the panels, and put the matching ingredients after the 4 groups. |
|
@stephanegigandet I think you did some work on it already, didn't you ? In this case we can close this PR. |
|
Not fixed yet |
github-actions
bot
added
the
⏰ Stale
There was a problem hiding this comment.
LGTM, although it would be better not to introduce
as asked by @stephanegigandet
teolemon
added
the
Nova - Ultra-processed foods
|
@alexgarel how about we merge that one ? |
|
Can you fix things proposed by @stephanegigandet, @teolemon ? |
|
@alexgarel is it better ? |
|
Kudos, SonarCloud Quality Gate passed!
|
What
fix: make NOVA panel clearer
Part of