Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Several fixes for product addition #5978

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Dec 1, 2024

Hi everyone!

Here are a few fixes for the product addition screen.

From the carousel

The screen was displayed with tabs + non-functioning exit buttons (#5975).

Blocking product selection

The next button was blocked, but the scroll was still possible

Buttons bar in dark mode

Old visual:
IMG_1532

Button in dark mode (#5961)

New color:
IMG_1534

@github-actions github-actions bot added 🥫 Product page 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. labels Dec 1, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 6.50%. Comparing base (4d9c7fc) to head (488598c).
Report is 546 commits behind head on develop.

Files with missing lines Patch % Lines
.../product/add_new_product/add_new_product_page.dart 0.00% 7 Missing ⚠️
...app/lib/pages/product/product_incomplete_card.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5978      +/-   ##
==========================================
- Coverage     9.54%   6.50%   -3.05%     
==========================================
  Files          325     441     +116     
  Lines        16411   24977    +8566     
==========================================
+ Hits          1567    1624      +57     
- Misses       14844   23353    +8509     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, those were blockers.

@teolemon teolemon merged commit 40ad716 into openfoodfacts:develop Dec 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥫 Product page 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

We can't exit the product addition wizard from the carousel Dark mode issue in product addition
3 participants