Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Country selector button invisible in dark mode #5979

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Dec 1, 2024

Hi everyone!

Here's a very minor issue.
In the country selector and in dark mode, the "Save" button was invisible:

Before/After:
Untitled

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 6.50%. Comparing base (4d9c7fc) to head (2a1020f).
Report is 546 commits behind head on develop.

Files with missing lines Patch % Lines
...preferences/country_selector/country_selector.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5979      +/-   ##
==========================================
- Coverage     9.54%   6.50%   -3.05%     
==========================================
  Files          325     441     +116     
  Lines        16411   24974    +8563     
==========================================
+ Hits          1567    1624      +57     
- Misses       14844   23350    +8506     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon added darkmode Ensuring we look good in the dark countries labels Dec 1, 2024
@teolemon teolemon merged commit ee168fd into openfoodfacts:develop Dec 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
countries darkmode Ensuring we look good in the dark
Development

Successfully merging this pull request may close these issues.

3 participants