fix(frontend): Prevent users from navigating to child with unsaved changes #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perierc
reviewed
Mar 27, 2024
taxonomy-editor-frontend/src/pages/project/editentry/ListEntryChildren.tsx
Outdated
Show resolved
Hide resolved
taxonomy-editor-frontend/src/pages/project/editentry/ListEntryChildren.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
148
to
152
| to={ | ||
| hasChanges | ||
| ? "#" | ||
| : `${urlPrefix}/entry/${relationObject["child"]}` | ||
| } |
There was a problem hiding this comment.
The Alert is a wonderful idea, but I don't think we should change the link: imagine a user wants to open an existing child node in a new tab with a ctrl+click or right-click+open in new tab.
I think we should only remove the link for newly created children.
There was a problem hiding this comment.
The loss of changes is however a big deal @perierc
As we have hasChanges I think there is a way to handle that by warning the user if he tries to close the page (or navigate away):
see https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event
It might be in another PR though.
alexgarel
approved these changes
Apr 11, 2024
alexgarel
deleted the
piv94165/prevent-click-on-new-child-before-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently, users can navigate to a child node while editing a parent node without saving changes, resulting in a potential 404 error if the child node is newly created.
Additionally, clicking on a child node before saving changes can lead to the loss of unsaved modifications.
To prevent this, I have disabled the ability to navigate to a child node if this node has been newly created without saving.
Furthermore, I have implemented a warning message to inform users about why they cannot proceed to the child node : "You've just created a new child. To navigate to it, please ensure your changes are saved first."
There is another warning massage when whatever changes have not been saved : "Changes are pending and have not been saved. Please save your changes before navigating to any child node. If you prefer not to save your pending changes but wish to avoid losing them, you can navigate to a child node in a new window."
What can be added :
Screenshot
The child node has been added whithout saving :
A change has not been saved :
