Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of pkg_resources #542

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Remove use of pkg_resources #542

merged 4 commits into from
Nov 15, 2023

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Nov 13, 2023 •
edited
Loading

Description

This PR migrates entry point management and testing to use importlib.metadata instead of the deprecated (as an PI) pkg_resources. Resolves #505

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Update property plugin management
  • Update taproom plugin management
  • Refactor some common utility functions
  • Update tests

Status

  • Ready to go

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

Merging #542 (7a15f50) into main (90e7053) will increase coverage by 0.12%.
Report is 2 commits behind head on main.
The diff coverage is 92.85%.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review November 13, 2023 20:45
@mattwthompson mattwthompson merged commit 6575945 into main Nov 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove use of pkg_resources
1 participant
@mattwthompson